New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove restriction on using compile + sharding #707

Merged

tgaddair merged 1 commit into main from compile-sharded

Dec 9, 2024

Contributor

tgaddair commented Dec 9, 2024

This restriction applied to earlier versions of PyTorch + NCCL where some limitations existed, but modern versions seem to work fine without issue.


          Remove restriction on using compile + sharding

c1480f0

tgaddair requested a review from magdyksaleh

December 9, 2024 18:39

magdyksaleh approved these changes

View reviewed changes

tgaddair merged commit 63c5eb3 into main

1 check passed

tgaddair deleted the compile-sharded branch

December 9, 2024 18:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet